Replace Hack Club example emails with KiwiHacks ones - #7
Open
N1k0s1 wants to merge 2 commits into
Open
Conversation
The signup/login email placeholder, the API docs examples, and the mailer previews all still showed Hack Club addresses and the Orpheus mascot. Swapped every example address to kiki@kiwihacks.org (Kiki is the KiwiHacks mascot) and renamed the preview identity to match. Spec fixture addresses and the whoami CORS origin move to kiwihacks.org too, so no test data points at a domain we don't own. Closes #3 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X9XgkkN9VbgQH4ejEF2Ubj
…n-in-email # Conflicts: # app/views/docs/api.md.erb # config/locales/en.yml # spec/factories/identities.rb # spec/requests/api/external/whoami_spec.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
The signup/login email placeholder, the API docs examples, and the mailer previews all still showed Hack Club addresses and the Orpheus mascot. Every example address is now
kiki@kiwihacks.org(Kiki is the KiwiHacks mascot), and the preview identity is renamed to match.User-visible
config/locales/en.yml— signup + login email fieldorpheus@dino.mailkiki@kiwihacks.orgapp/views/email_changes/new.html.erb— new-email fieldnew@electronic.mailkiki@kiwihacks.orgapp/views/docs/api.md.erb—/docs/apiorpheus@example.comkiki@kiwihacks.orgapp/views/static_pages/external_api_docs.html.erb—/api/externalnora@hackclub.comkiki@kiwihacks.orgMailer previews
Six files under
spec/mailers/previews/—first_name: "Orpheus"→"Kiki",orpheus@hackclub.com→kiki@kiwihacks.org. The email-change preview's destination address becomeskiki.new@kiwihacks.orgso it stays distinct from the old address.Test data
spec/factories/identities.rb,spec/models/identity/email_change_request_spec.rb, andspec/requests/api/external/whoami_spec.rb— fixture addresses and the whoami CORS origin (https://program.hackclub.com→https://program.kiwihacks.org) now use a domain we own.Testing
bundle exec rspec— 287 examples, 36 failures, byte-identical to the failure list on the unmodified branch. All pre-existing, none in files this PR touches.bundle exec rspec -O /dev/null spec/models/identity/email_change_request_spec.rb spec/requests/api/external/whoami_spec.rb— 44 examples, 0 failures. (-O /dev/nullis needed because.rspec's--patternotherwise overrides file arguments.)bin/lintclean on the changed files.bin/rails s:/login,/signup, and/docs/apiall servekiki@kiwihacks.org; all six mailer previews return 200 with noOrpheusorhackclub.comleft in the bodies.Not verified locally
/api/external500s onmainand on this branch alike —app/views/layouts/backend.html.erb:22calls an undefinedbreadcrumbs. Unrelated to this change, but it means that page's example could not be eyeballed./email_changes/newsits behind step-up auth, and the login code is delivered via Loops, which isn't configured in local dev. The placeholder there is a plain string literal in the ERB.Unrelated issue spotted
db/schema.rbis out of date versusdb/migrate/—20260726060000_drop_persona_integration.rbis not reflected in it, sobundle exec rspecaborts withPendingMigrationErroron a fresh checkout until you runRAILS_ENV=test bin/rails db:migrate. Left out of this PR to keep the diff focused.Also left alone:
app/views/slack/**/*.slocksstill carries upstream Hack Club conduct links,conduct@hackclub.com, and:orpheus-*:emoji. Those are real links rather than examples and look like a separate porting job.🤖 Generated with Claude Code
https://claude.ai/code/session_01X9XgkkN9VbgQH4ejEF2Ubj