chore(deps): bump the major group across 1 directory with 4 updates - #310
chore(deps): bump the major group across 1 directory with 4 updates#310dependabot[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
| @@ -26,7 +26,7 @@ path = "src/lib.rs" | |||
| # --workspace` on Linux / Windows CI does not try to resolve the | |||
| # swift-rs crate from the registry at all. | |||
| [target.'cfg(target_os = "macos")'.build-dependencies] | |||
There was a problem hiding this comment.
WARNING: swift-rs 1.0 removes the 0.1 build_utils free-function API that build.rs depends on.
build.rs (lines 45-54) calls swift_rs::build_utils::{link_swift, link_swift_package} — the swift-rs 0.1 free-function API. swift-rs 1.0 (the "newer line" your own build.rs comment contrasts against) replaced this with the SwiftLinker builder API, so cargo build -p byteport-macos-share --features link-swift on macOS will fail to compile. Either migrate build.rs to the 1.0 SwiftLinker API or keep swift-rs = "0.1" until that migration lands.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| zvariant = "4" | ||
| zbus = { version = "5", default-features = false, features = ["tokio"] } | ||
| zvariant = "5" | ||
| tokio = { version = "1", features = ["rt", "macros"] } |
There was a problem hiding this comment.
WARNING: Major bump to zbus 5 — verify the scaffold still compiles against the v5 API.
This crate's source (src/ipc.rs, src/dbus.rs) uses zbus::ConnectionBuilder::session(), zbus::Proxy::new(...), zbus::SignalStream, and the #[dbus_interface(signal)] macro. zbus 5 is a major release with breaking changes (e.g. ConnectionBuilder reworked into connection::Builder, connection-constructor changes). cargo check --workspace does not exercise this crate on non-Linux CI, so confirm a Linux target still builds before merge.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| @@ -19,8 +19,8 @@ path = "src/lib.rs" | |||
| # pairs cleanly with our stable `tokio = 1` runtime elsewhere in the | |||
There was a problem hiding this comment.
SUGGESTION: Stale rationale comment now contradicts the version bump.
The comment block (lines 19-22) states "zbus 4 is selected over 5 because 4 is the last release line that pins tokio as an optional feature (rather than a hard default)". This crate now pins zbus = "5" (line 24), so that justification is void. Update the comment to reflect that zbus 5 is selected via default-features = false, features = ["tokio"].
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Previous Review Summary (commit cbf573c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit cbf573c)Status: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Considerations (not inline)
Files Reviewed (4 files)
Reviewed by step-3.7-flash · Input: 163.9K · Output: 18.7K · Cached: 892K |
cbf573c to
0573d53
Compare
Bumps the major group with 4 updates in the / directory: [swift-rs](https://github.com/Brendonovich/swift-rs), [ndk](https://github.com/rust-mobile/ndk), [zbus](https://github.com/z-galaxy/zbus) and [zvariant](https://github.com/z-galaxy/zbus). Updates `swift-rs` from 0.1.0 to 1.0.7 - [Release notes](https://github.com/Brendonovich/swift-rs/releases) - [Commits](Brendonovich/swift-rs@0.1.0...1.0.7) Updates `ndk` from 0.8.0 to 0.9.0 - [Release notes](https://github.com/rust-mobile/ndk/releases) - [Commits](rust-mobile/ndk@ndk-0.8.0...ndk-0.9.0) Updates `zbus` from 4.4.0 to 5.12.0 - [Release notes](https://github.com/z-galaxy/zbus/releases) - [Changelog](https://github.com/z-galaxy/zbus/blob/main/release-plz.toml) - [Commits](z-galaxy/zbus@zbus-4.4.0...zbus-5.12.0) Updates `zvariant` from 4.2.0 to 5.8.0 - [Release notes](https://github.com/z-galaxy/zbus/releases) - [Changelog](https://github.com/z-galaxy/zbus/blob/main/release-plz.toml) - [Commits](z-galaxy/zbus@zvariant-4.2.0...zvariant-5.8.0) --- updated-dependencies: - dependency-name: ndk dependency-version: 0.9.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: major - dependency-name: swift-rs dependency-version: 1.0.7 dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: zbus dependency-version: 5.12.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: major - dependency-name: zvariant dependency-version: 5.8.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: major ... Signed-off-by: dependabot[bot] <support@github.com>
0573d53 to
2fbbac0
Compare
|
Skipping PR review because a bot author is detected. If you want to trigger CodeAnt AI, comment |
|



Bumps the major group with 4 updates in the / directory: swift-rs, ndk, zbus and zvariant.
Updates
swift-rsfrom 0.1.0 to 1.0.7Release notes
Sourced from swift-rs's releases.
... (truncated)
Commits
f64a451Merge pull request #66 from lucasfernog/fix/set-swift-target0bfa71bfix(build): set Swift target triple634301fMerge pull request #58 from MarvelousAnything/main50a909d[Add] --arch arg to swift build command.5fc773dMerge pull request #56 from DaAitch/fix-README6bb3863fix README.md dead linkb5ed223v1.0.61416862Merge pull request #55 from Brendonovich/cleanup6619709cleanup + add docsf456dbaMerge pull request #54 from Brendonovich/50-force-using-system-clangUpdates
ndkfrom 0.8.0 to 0.9.0Release notes
Sourced from ndk's releases.
Commits
49bbbbaRelease ndk-sys-0.6.0, ndk-0.9.0 (#472)9ba82abndk/image_reader: Special-case return statuses inImage-acquire functions (...ce07460ndk-sys: Generate against latest upstream NDK (11769913) (#471)6893a70looper: RequireSendwhen adding fd event callbacks onForeignLooper(#469)e932c84ndk/audio: MergeAudioResultvariant enum intoAudioError(#467)575489bndk/native_window: Link againstlibnativewindowfor API >= 26 functions (#465)ec19614ndk/hardware_buffer: ConvertHardwareBufferUsagetobitflags(#461)3a25c1andk: Mark all enums asnon_exhaustiveand fixreprtypes (#459)a16f995ndk/native_window: Remove redundantTRANSFORM_prefix from `NativeWindowTra...0b9c573ndk: Requre all off-threaddyn Fn*callback types to implementSend(#455)Updates
zbusfrom 4.4.0 to 5.12.0Release notes
Sourced from zbus's releases.
... (truncated)
Commits
d4254d6Merge pull request #1544 from zeenix/releasesbd399ae🔖 zb: Release 5.12.014fce7c🔖 zv: Release 5.8.033cb56c🚚 Update name of Github space from dbus2 to z-galaxya00e93c⬆️ micro: Update clap to v4.5.49 (#1540)7c2baf6Merge pull request #1538 from dbus2/renovate/actions-checkout-5.x5ac2239⬆️ Update actions/checkout action to v5c9a00eaMerge pull request #1537 from DarthB/codspeed562f125use codspeed benchmarks with criterion compat layer4dc5325⬆️ micro: Update serde to v1.0.228 (#1534)Updates
zvariantfrom 4.2.0 to 5.8.0Release notes
Sourced from zvariant's releases.
... (truncated)
Commits
14fce7c🔖 zv: Release 5.8.0a00e93c⬆️ micro: Update clap to v4.5.49 (#1540)7c2baf6Merge pull request #1538 from dbus2/renovate/actions-checkout-5.x5ac2239⬆️ Update actions/checkout action to v5c9a00eaMerge pull request #1537 from DarthB/codspeed562f125use codspeed benchmarks with criterion compat layer4dc5325⬆️ micro: Update serde to v1.0.228 (#1534)921e0e9⬆️ micro: Update windows-sys to v0.61.2 (#1535)54dea5d⬆️ micro: Update quote to v1.0.41 (#1533)c407d50⬆️ micro: Update camino to v1.2.1 (#1532)Note
Bump major versions of ndk, zbus, zvariant, and swift-rs dependencies
ndk0.8 → 0.9zbusandzvariantv4 → v5swift-rs0.1 → 1.0Macroscope summarized 2fbbac0.