Skip to content

feat-nvms-container-runtime-adapter - #334

Draft
KooshaPari wants to merge 2 commits into
mainfrom
codex/byteport-container-runtime-adapter-20260805
Draft

feat-nvms-container-runtime-adapter#334
KooshaPari wants to merge 2 commits into
mainfrom
codex/byteport-container-runtime-adapter-20260805

Conversation

@KooshaPari

Copy link
Copy Markdown
Owner

Summary

  • Route the existing NVMS container-manager API through an explicit runtime adapter.
  • Default to Podman; support WSL Containers (wslc) and Apple Containers (container).
  • Reject Docker selectors explicitly and render neutral Containerfile/byteport-container.ps1 artifacts without Docker CLI commands.
  • Preserve DockerManager as a source-compatible alias while making the backend boundary explicit.

Validation

  • gofmt and git diff --check pass.
  • Added focused tests for default selection, Docker rejection, adapter rendering, and neutral build artifacts.
  • go test ./lib is currently blocked before package tests by the external dependency github.com/fermyon/spin/sdk/go/v2/http@v2.2.0: internals.go:16 has an export-comment mismatch (spin_http_handle_http_request, want handle_http_request).
  • No container runtime was invoked by this change.

Scope

This PR is intentionally separate from BytePort PR #333 and covers only the no-Docker NVMS adapter boundary.

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant