Skip to content

Indentation of block-like brackets followed by chained call - #635

Open
ptitjes wants to merge 1 commit into
Kotlin:mainfrom
ptitjes:p/631-brackets-followed-by-chained-call
Open

Indentation of block-like brackets followed by chained call#635
ptitjes wants to merge 1 commit into
Kotlin:mainfrom
ptitjes:p/631-brackets-followed-by-chained-call

Conversation

@ptitjes

@ptitjes ptitjes commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Closes #631

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 27, 2026
@hick209 hick209 changed the title Indentation of block-like brackets followed by chained call Indentation of block-like brackets followed by chained call [2/2] Jun 29, 2026
@hick209 hick209 changed the title Indentation of block-like brackets followed by chained call [2/2] Indentation of block-like brackets followed by chained call Jun 29, 2026
@hick209 hick209 linked an issue Jun 29, 2026 that may be closed by this pull request
@ptitjes
ptitjes force-pushed the p/631-brackets-followed-by-chained-call branch from ee1e2dd to 7787486 Compare July 6, 2026 07:48
@hick209

hick209 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

I think we need a rebase of this one here, it failed to import

@ptitjes

ptitjes commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@hick209 I am really sorry I did not have the chance to work on this in the last weeks. I intend to be back at it during August. I hope this can wait then.

@ptitjes
ptitjes force-pushed the p/631-brackets-followed-by-chained-call branch from 1c7aa82 to 3ace200 Compare August 11, 2026 10:24
@ptitjes

ptitjes commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

@hick209 I fully rebased the PR on main, cleaned up the implementation, fixed an existing test and added an additional test.

Disclaimer: the tests and the initial implementation were LLM-generated. I reviewed and modified the implementation manually.

@AbdullinAM

Copy link
Copy Markdown
Member

@ptitjes Hey! We're currently in the process of changing a lot of stuff around, especially with tests. So this will probably require another rebase soon. I can take it over and rebase/merge this when everything will stabilise if there are no other comments from @hick209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Brackets are formatted in a weird way when followed by chained calls Strange formatting for lambda with chained function call

3 participants