Migrate formatting tests to file-based approach - #667
Merged
Conversation
AbdullinAM
force-pushed
the
abdullin/tests
branch
from
August 11, 2026 11:58
de54887 to
9e7e9d8
Compare
Member
|
Note: we'll check if |
AbdullinAM
force-pushed
the
abdullin/tests
branch
from
August 11, 2026 13:32
9e7e9d8 to
6a2ab1a
Compare
AbdullinAM
force-pushed
the
abdullin/tests
branch
from
August 11, 2026 16:27
6a2ab1a to
30a6f1e
Compare
qwwdfsad
reviewed
Aug 11, 2026
qwwdfsad
left a comment
qwwdfsad
left a comment
Member
There was a problem hiding this comment.
I haven't manually looked through every test case obviously, only infra, I assume you've used some kind of deterministic automatic migration for that (worth noting in the squashed commit message for the history sake).
I see there are around ~70 new tests (863 vs 797), could you please elaborate on where they came from?
* Replace `FormatterTest` and `GoogleStyleFormatterKtTest` with file-based cases under cases/ * Move parse-error tests from `FormatterTest` to `ParserTest`
AbdullinAM
force-pushed
the
abdullin/tests
branch
from
August 12, 2026 08:46
30a6f1e to
507f372
Compare
qwwdfsad
approved these changes
Aug 12, 2026
qwwdfsad
left a comment
qwwdfsad
left a comment
Member
There was a problem hiding this comment.
+7000, -11000 LGTM 👍
(that's me trying to be funny, all good)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The total amount of tests has changed from 797 to 867. This difference comes from:
.outputfile we also generate an additionalFormat is idempotenttest. This accounts for 100 new testsNote 2:
KDocFormatterTestis still left in its original form, it will require more handling and will be addressed in a separate commit later. This PR is just migration of tests that I have already processed in a separate fork