Visitor refactoring - #668
Open
AbdullinAM wants to merge 7 commits into
Open
Conversation
…nd migrate KotlinInputAstVisitor to it
Extract formatting of file-level psi nodes to a separate visitor
AbdullinAM
commented
Aug 11, 2026
AbdullinAM
force-pushed
the
abdullin/visitor-refactoring
branch
from
August 11, 2026 16:05
3c3c9d7 to
f0c43e0
Compare
AbdullinAM
marked this pull request as ready for review
August 11, 2026 16:05
AbdullinAM
force-pushed
the
abdullin/visitor-refactoring
branch
from
August 11, 2026 16:21
f0c43e0 to
96638b8
Compare
TypeFormatter depends on ListFormatter, so we have to extract them simultaneously
AbdullinAM
force-pushed
the
abdullin/visitor-refactoring
branch
from
August 11, 2026 16:26
96638b8 to
fd1f2c7
Compare
qwwdfsad
force-pushed
the
abdullin/visitor-refactoring
branch
from
August 12, 2026 17:15
261d134 to
db0be90
Compare
…ever a chance formatter removes the code Also, adjust broken package
qwwdfsad
force-pushed
the
abdullin/visitor-refactoring
branch
from
August 12, 2026 17:31
efff0ae to
cb64804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: simplify
KotlinInputAstVisitorby separating it into separate independent formatter visitors responsible for small subsystems. This is an initial prototype, the separation will continue in the following PRsNote: this is just general idea for the structure, I haven't refactored the 'contents' of the moved functions. I plan to do that after the split