fix(ci): run knowledge + serve gates with their declared extras#111
Merged
Conversation
knowledge-test and serve-test put `sync-args` on raw `astral-sh/setup-uv@v7`, which has no such input (silently ignored) — so --extra stores/skills-rag/ml (knowledge) and --all-extras (serve) never installed. knowledge tests were import-guarded into skips (vacuous green); serve ran without stores/pyarrow. Switch both to the local composite `./.github/actions/uv-setup`, which actually runs `uv sync ${sync-args}` (same pattern lint/test already use). Verified locally with extras present: knowledge 255 passed, serve 93 passed.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017pXsj4Q7q1Vn2mtHhakTtJ
Signed-off-by: se-jo-ma <mauk.sean@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
knowledge-testandserve-testdeclare extras viaastral-sh/setup-uv'ssync-argsinput — setup-uv has no such input (silently ignored, same root cause as #110's cypher-subset). So:--extra stores --extra skills-rag --extra mlnever installed → the knowledge suite was import-guarded into skips (vacuous green, ~0 real coverage).--all-extras --all-groupsnever installed → serve ran withoutstores/pyarrow/ml.lintandtestwere already correct — they use the local composite./.github/actions/uv-setup, which runsuv sync ${sync-args}. Only these two used raw setup-uv.Fix
Point both jobs at the same composite (one-line
uses:swap each). Nouv runchanges needed — the composite's explicituv syncpersists the extras across steps.Verified locally (linux, py3.13, extras present)
knowledgemarker: 255 passed, 14 skipped (runslow), 1 xfailedservemarker: 93 passed, 5 skipped (runslow)uv sync --all-extras --all-groupsresolves+installs clean (no source builds blocking).lintjob (full-codebase strict).Leaves cypher-subset as fixed in #110 (inline
uv run --extra). No behavior change to lint/test.🤖 Generated with Claude Code