Skip to content

[dbtool] Backup/Restore perf improvements - #505

Merged
christianparpart merged 2 commits into
masterfrom
tracy-backup-instrumentation
Jun 17, 2026
Merged

[dbtool] Backup/Restore perf improvements#505
christianparpart merged 2 commits into
masterfrom
tracy-backup-instrumentation

Conversation

@Yaraslaut

@Yaraslaut Yaraslaut commented Jun 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

some perf numbers for the MS SQL

  Backup

  ┌──────┬────────┬────────┬─────────┐
  │ jobs │ master │ branch │ speedup │
  ├──────┼────────┼────────┼─────────┤
  │ 1    │ 2.11 s │ 1.74 s │ 1.22×   │
  ├──────┼────────┼────────┼─────────┤
  │ 2    │ 2.11 s │ 0.97 s │ 2.17×   │
  ├──────┼────────┼────────┼─────────┤
  │ 4    │ 2.11 s │ 0.60 s │ 3.50×   │
  ├──────┼────────┼────────┼─────────┤
  │ 8    │ 2.09 s │ 0.48 s │ 4.35×   │
  └──────┴────────┴────────┴─────────┘

  Restore

  ┌──────┬────────┬────────┬─────────┐
  │ jobs │ master │ branch │ speedup │
  ├──────┼────────┼────────┼─────────┤
  │ 1    │ 6.77 s │ 6.80 s │ 0.99×   │
  ├──────┼────────┼────────┼─────────┤
  │ 4    │ 6.69 s │ 3.77 s │ 1.77×   │
  ├──────┼────────┼────────┼─────────┤
  │ 8    │ 6.84 s │ 2.21 s │ 3.10×   │
  └──────┴────────┴────────┴─────────┘

@github-actions github-actions Bot added documentation Improvements or additions to documentation CLI command line interface tools tests Data Binder SQL Data Binder support Core API Query Formatter SQL dialect implementations labels Jun 10, 2026
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch from 53235e6 to 5179abd Compare June 10, 2026 13:10
@Yaraslaut Yaraslaut changed the title Tracy backup instrumentation [dbtool] Backup/Restore perf improvements Jun 10, 2026
christianparpart
christianparpart reviewed Jun 11, 2026
View reviewed changes
Comment thread src/Lightweight/DataBinder/BasicStringBinder.hpp Outdated
christianparpart
christianparpart reviewed Jun 11, 2026
View reviewed changes
Comment thread src/Lightweight/DataBinder/UnicodeConverter.hpp Outdated
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch from 5179abd to 0ef8f61 Compare June 12, 2026 07:35
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch 2 times, most recently from c4e1d9c to ffe577e Compare June 12, 2026 07:53
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch 6 times, most recently from 1d7aef1 to 320c70e Compare June 14, 2026 16:20
@Yaraslaut
Yaraslaut marked this pull request as ready for review June 14, 2026 16:20
@Yaraslaut
Yaraslaut requested a review from a team as a code owner June 14, 2026 16:20
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch 4 times, most recently from 6a62d9f to 8fd3eda Compare June 15, 2026 08:27
christianparpart
christianparpart requested changes Jun 15, 2026
View reviewed changes

@christianparpart christianparpart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall okay, but a few things to mention / change.

Comment thread src/Lightweight/SqlStatement.cpp Outdated
Comment thread src/Lightweight/SqlBackup/Backup.cpp
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/Lightweight/SqlBackup/ChunkPlanner.cpp Outdated
Comment thread src/tools/dbtool/BackupDiff.hpp Outdated
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch from 8fd3eda to ea51d09 Compare June 15, 2026 15:41
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch from 744460b to f86b33a Compare June 17, 2026 08:08
@Yaraslaut
Yaraslaut force-pushed the tracy-backup-instrumentation branch from f86b33a to 9289b4b Compare June 17, 2026 08:37
@christianparpart
christianparpart merged commit 0f4c5bd into master Jun 17, 2026
28 checks passed
@christianparpart
christianparpart deleted the tracy-backup-instrumentation branch June 17, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianparpart christianparpart christianparpart requested changes

Assignees

No one assigned

Labels

CLI command line interface tools Core API Data Binder SQL Data Binder support documentation Improvements or additions to documentation Query Formatter SQL dialect implementations tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yaraslaut @christianparpart