LKSM: Multivalue text choice automation: Type Conversion by DariaBod · Pull Request #2960 · LabKey/testAutomation

DariaBod · 2026-04-21T23:57:35Z

Rationale

Added tests for type conversion MVTC->TC, TC->MVTC, MVTC->Text for for saved custom grid views with all array type filters.
Also added test to verify MVTC cannot convert to TC if any row has >1 values, cross folder scenario, if rows with multi value is in child/sibling folder only.

Related Pull Requests

https://github.com/LabKey/limsModules/pull/2136

Changes

some fixes

delete github issue links

labkey-tchad

Several suggestions. (Claude /review-pr was useful)

labkey-tchad · 2026-04-23T21:23:14Z

    // it is in the product).

-    public void setAllowMultipleSelections(Boolean allowMultipleSelections)
+    public DomainFieldRow setAllowMultipleSelections(Boolean allowMultipleSelections)


Add a parameter to explicitly determine whether a confirmation dialog is expected. This is consistent with the setType method.

Suggested change

public DomainFieldRow setAllowMultipleSelections(Boolean allowMultipleSelections)

public DomainFieldRow setAllowMultipleSelections(Boolean allowMultipleSelections, boolean confirmDialogExpected)

Without this change, the component might fail to dismiss a dialog that appears a little too slowly.

labkey-tchad · 2026-04-23T21:44:05Z


        log("Validate that the order of the fields in the 'Shown in Grid' column are as expected.");
-        expectedFields = List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL);
+        expectedFields = List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL, COL_MULTITEXTCHOICE);


The list of expected fields should be conditional

Suggested change

expectedFields = List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL, COL_MULTITEXTCHOICE);

expectedFields = MULTI_CHOICE_ENABLED

? List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL, COL_MULTITEXTCHOICE)

: List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL);

labkey-tchad · 2026-04-23T21:46:32Z

     * @param columns The columns to show in the default view. Will be added in the order of the list.
     */
-    private void resetDefaultView(String sampleTypeName, List<String> columns) throws Exception
+    private void resetDefaultView(String projectPath, String sampleTypeName, List<String> columns) throws Exception


Why add this path parameter? It is never anything but getProjectName().

labkey-tchad · 2026-04-23T21:57:00Z

+    private record GridConversionResult(boolean isDropped, @Nullable String expectedFilterText)
+    {
+        static GridConversionResult kept(String filterText) { return new GridConversionResult(false, filterText); }
+        static GridConversionResult dropped()               { return new GridConversionResult(true, null); }
+    }


Add more documentation. Claude is great at this.

Suggested change

private record GridConversionResult(boolean isDropped, @Nullable String expectedFilterText)

{

static GridConversionResult kept(String filterText) { return new GridConversionResult(false, filterText); }

static GridConversionResult dropped() { return new GridConversionResult(true, null); }

}

/**

* Describes the expected state of a saved grid view's filter pill after a field type conversion.

*

* @param isDropped {@code true} if the filter is expected to be silently dropped by the conversion

* (i.e., no filter pill should be visible); {@code false} if the filter should survive.

* @param expectedFilterText the substring expected to appear in the filter pill after conversion;

* {@code null} when {@code isDropped} is {@code true}.

*/

private record GridConversionResult(boolean isDropped, @Nullable String expectedFilterText)

{

/** The filter survives conversion and its pill should contain {@code filterText}. */

static GridConversionResult kept(String filterText) { return new GridConversionResult(false, filterText); }

/** The filter is silently dropped by the conversion; no filter pill should be visible. */

static GridConversionResult dropped() { return new GridConversionResult(true, null); }

}

labkey-tchad · 2026-04-23T21:58:17Z

+    private record GridMVTCCase(String viewName, Filter.Operator op, String[] filterVals,
+                                GridConversionResult conversionResult,
+                                Map<String, String> expectedSampleMap) {}
+
+    private record GridTCCase(String viewName, Filter.Operator op, String[] filterVals,
+                              String expectedAfterConversionText,
+                              Map<String, String> expectedSampleMap) {}


Add documentation to these as well

labkey-tchad · 2026-04-23T22:10:18Z

+    private void changeMVTCFieldToText()
+    {
+        UpdateSampleTypePage updatePage = beginAtSampleTypesList(this, getProjectName())
+                .goToEditSampleType(DEFAULT_VIEW_SAMPLE_TYPE);
+        updatePage.getFieldsPanel()
+                .getField(COL_MULTITEXTCHOICE)
+                .expand()
+                .setType(FieldDefinition.ColumnType.String, true);
+        updatePage.clickSave();
+    }


If any of these new tests fails while the column type has been changed, it could cause all of the subsequent MVTC tests to fail because the type is not as expected.

Consider having these type changer methods not depend on a certain initial type and alter their behavior based on the current type. Then each of the conversion tests could switch the column to MVTC at the start instead of having each of them switch back to MVTC at the end.

DariaBod added 9 commits April 13, 2026 11:47

sample finder conversion tests

4b9f539

test cross folder MVTC to TC conversion

66e4ae6

sample finder tests add mvtc field check after conversions

55909cd

Merge branch 'develop' into fb_typeConversionMVTC

18c9c1d

tests for saved grid type conversion

f860fd4

Merge branch 'develop' into fb_typeConversionMVTC

0712051

small fixes

a0c65e8

Merge branch 'develop' into fb_typeConversionMVTC

6dfa7df

subfolder test move to LKSM

c4b5608

some fixes

DariaBod requested review from XingY, labkey-danield and labkey-tchad April 21, 2026 23:57

DariaBod added 2 commits April 22, 2026 09:28

fix code style

7196093

delete github issue links

Merge branch 'develop' into fb_typeConversionMVTC

0c2fcc1

XingY approved these changes Apr 23, 2026

View reviewed changes

labkey-tchad approved these changes Apr 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LKSM: Multivalue text choice automation: Type Conversion#2960

LKSM: Multivalue text choice automation: Type Conversion#2960
DariaBod wants to merge 11 commits intodevelopfrom
fb_typeConversionMVTC

DariaBod commented Apr 21, 2026

Uh oh!

labkey-tchad left a comment

Uh oh!

labkey-tchad Apr 23, 2026

Uh oh!

labkey-tchad Apr 23, 2026

Uh oh!

labkey-tchad Apr 23, 2026

Uh oh!

labkey-tchad Apr 23, 2026

Uh oh!

labkey-tchad Apr 23, 2026

Uh oh!

labkey-tchad Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public DomainFieldRow setAllowMultipleSelections(Boolean allowMultipleSelections)
	public DomainFieldRow setAllowMultipleSelections(Boolean allowMultipleSelections, boolean confirmDialogExpected)

-        expectedFields = List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL, COL_MULTITEXTCHOICE);
+        expectedFields = MULTI_CHOICE_ENABLED
+                ? List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL, COL_MULTITEXTCHOICE)
+                : List.of(COL_NAME, COL_STRING1, COL_STRING2, COL_INT, COL_BOOL);

-    private record GridConversionResult(boolean isDropped, @Nullable String expectedFilterText)
-    {
-        static GridConversionResult kept(String filterText) { return new GridConversionResult(false, filterText); }
-        static GridConversionResult dropped()               { return new GridConversionResult(true, null); }
-    }
+    /**
+     * Describes the expected state of a saved grid view's filter pill after a field type conversion.
+     *
+     * @param isDropped          {@code true} if the filter is expected to be silently dropped by the conversion
+     *                           (i.e., no filter pill should be visible); {@code false} if the filter should survive.
+     * @param expectedFilterText the substring expected to appear in the filter pill after conversion;
+     *                           {@code null} when {@code isDropped} is {@code true}.
+     */
+    private record GridConversionResult(boolean isDropped, @Nullable String expectedFilterText)
+    {
+        /** The filter survives conversion and its pill should contain {@code filterText}. */
+        static GridConversionResult kept(String filterText) { return new GridConversionResult(false, filterText); }
+        /** The filter is silently dropped by the conversion; no filter pill should be visible. */
+        static GridConversionResult dropped()               { return new GridConversionResult(true, null); }
+    }

Conversation

DariaBod commented Apr 21, 2026

Rationale

Related Pull Requests

Changes

Uh oh!

labkey-tchad left a comment

Choose a reason for hiding this comment

Uh oh!

labkey-tchad Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

labkey-tchad Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

labkey-tchad Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

labkey-tchad Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

labkey-tchad Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

labkey-tchad Apr 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants