More CageUI Fixes#948
Merged
dnicolalde merged 25 commits intorelease25.7-SNAPSHOTfrom Apr 23, 2026
Merged
Conversation
…ned to close to the edge
…enus on mobile devices
…layout, and opening context menus
If a user submitted a mod after saving the table with no mod between cages this would break the mods from loading. This change ensures that default mods are added after the user saves the current mods for a cage, if no separator mods exist in that section.
dnicolalde
reviewed
Apr 23, 2026
Collaborator
dnicolalde
left a comment
dnicolalde
left a comment
There was a problem hiding this comment.
can you look at the comment
| setCurrCage(prevCage); | ||
| }, [prevCage]); | ||
|
|
||
| /*useEffect(() => { |
Collaborator
There was a problem hiding this comment.
why do you have this commented from the code?
dnicolalde
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Additional changes and fixes requested by the users for the CageUI. This branch might include changes that we added last time because I used the same branch for the newer fixes.
Related Pull Requests
https://github.com/LabKey/wnprc-modules/pull/938
Changes