Skip to content

load cascade child once per ref in fk cascade delete #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fabracht merged 2 commits into from
May 20, 2026
Merged

load cascade child once per ref in fk cascade delete #64

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16636db
load cascade child once per ref in fk cascade delete
fabracht May 20, 2026
74d4aed
Merge branch 'main' into perf/23-cascade-single-read
fabracht May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 32 additions & 33 deletions crates/mqdb-core/src/constraint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,12 @@ struct CrossOwnedRef {
owner: String,
}

enum CascadeChild {
Skip,
Missing,
Recurse(Entity),
}

pub struct ConstraintManager {
constraints: HashMap<String, Vec<Constraint>>,
}
Expand Down Expand Up @@ -326,32 +332,26 @@ impl ConstraintManager {
&entity.id,
)?;
for id in referencing {
if Self::is_cross_owned(
match Self::classify_cascade_child(
storage,
&fk.source_entity,
&fk.source_field,
&id,
ownership_ctx,
cross_owned,
)? {
continue;
}

let cascade_key = keys::encode_data_key(&fk.source_entity, &id);
if let Some(cascade_data) = storage.get(&cascade_key)? {
let cascade_entity = Entity::deserialize(
fk.source_entity.clone(),
id.clone(),
&cascade_data,
)?;
self.collect_delete_operations(
&cascade_entity,
storage,
all_operations,
visited,
cross_owned,
ownership_ctx,
)?;
CascadeChild::Skip => continue,
CascadeChild::Missing => {}
CascadeChild::Recurse(child_entity) => {
self.collect_delete_operations(
&child_entity,
storage,
all_operations,
visited,
cross_owned,
ownership_ctx,
)?;
}
}
all_operations.push(DeleteOperation::Cascade(CascadeOperation {
entity: fk.source_entity.clone(),
Expand Down Expand Up @@ -381,39 +381,38 @@ impl ConstraintManager {
Ok(())
}

fn is_cross_owned(
fn classify_cascade_child(
storage: &Storage,
source_entity: &str,
source_field: &str,
ref_id: &str,
ownership_ctx: Option<&OwnershipContext<'_>>,
cross_owned: &mut Vec<CrossOwnedRef>,
) -> Result<bool> {
let Some(ctx) = ownership_ctx else {
return Ok(false);
) -> Result<CascadeChild> {
let key = keys::encode_data_key(source_entity, ref_id);
let Some(data) = storage.get(&key)? else {
return Ok(CascadeChild::Missing);
};
let entity = Entity::deserialize(source_entity.to_string(), ref_id.to_string(), &data)?;

let Some(ctx) = ownership_ctx else {
return Ok(CascadeChild::Recurse(entity));
};
if ctx.ownership.is_admin(ctx.sender) {
return Ok(false);
return Ok(CascadeChild::Recurse(entity));
}

let Some(owner_field) = ctx.ownership.owner_field(source_entity) else {
return Ok(false);
return Ok(CascadeChild::Recurse(entity));
};

let key = keys::encode_data_key(source_entity, ref_id);
let Some(data) = storage.get(&key)? else {
return Ok(false);
};
let entity = Entity::deserialize(source_entity.to_string(), ref_id.to_string(), &data)?;
let owner = entity
.data
.get(owner_field)
.and_then(|v| v.as_str())
.unwrap_or("");

if owner == ctx.sender {
return Ok(false);
return Ok(CascadeChild::Recurse(entity));
}

cross_owned.push(CrossOwnedRef {
Expand All @@ -422,7 +421,7 @@ impl ConstraintManager {
field: source_field.to_string(),
owner: owner.to_string(),
});
Ok(true)
Ok(CascadeChild::Skip)
}

fn classify_cross_owned_danglers(
Expand Down
Loading