invalidate other sessions on password change#68
Open
fabracht wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionStore::destroy_others_by_canonical_id(canonical_id, keep_session_id) -> Vec<String>returning JWTs of removed sessions so callers can revoke their JTIs.POST /auth/password/changenow keeps the caller's session and destroys every other session for the samecanonical_id. JTIs from those JWTs are added toJtiRevocationStore.POST /auth/password/reset/submitdestroys all sessions for the target user (no current session at reset time) and revokes their JTIs.$DB/_auth/password/change) is intentionally out of scope —AdminContexthas no reference toSessionStore, and threading it through is plumbing for a separate PR.Closes #37 (HTTP scope); MQTT path tracked as follow-up.
Test plan
cargo make dev(format + clippy + 750 tests)session_store.rsfor the new method (keep-current-session / destroy-all / unknown-user)