Skip to content

Fix/issue 632 dashboard form a11y #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benedict315 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix/issue 632 dashboard form a11y #992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
826162d
a11y: add ids and htmlFor to dashboard form labels for accessibility …
jotel-dev Jul 11, 2026
75e5005
fix: resolve CI dependency conflicts - update vitest and ethnum
jotel-dev Jul 12, 2026
194df20
Merge branch 'main' into fix/issue-632-dashboard-form-a11y
Benedict315 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
"@types/supertest": "^6.0.3",
"@types/swagger-jsdoc": "^6.0.4",
"@types/swagger-ui-express": "^4.1.6",
"@vitest/coverage-v8": "^2.1.8",
"@vitest/coverage-v8": "^3.2.7",
"eventsource": "^2.0.2",
"nodemon": "^3.1.11",
"prisma": "^7.4.1",
"supertest": "^7.1.0",
"ts-node": "^10.9.2",
"tsx": "^4.19.2",
"typescript": "^5.9.3",
"vitest": "^3.2.4"
"vitest": "^3.2.7"
}
}
5 changes: 4 additions & 1 deletion contracts/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@ members = [
]

[workspace.dependencies]
soroban-sdk = "22.0.0"
soroban-sdk = "22.1.0"

[patch.crates-io]
ethnum = "1.5.3"

[profile.release]
opt-level = "z"
Expand Down
2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@
"jsdom": "^27.0.1",
"tailwindcss": "^4",
"typescript": "^5",
"vitest": "^2.1.9"
"vitest": "^3.2.7"
}
}
37 changes: 27 additions & 10 deletions frontend/src/components/dashboard/dashboard-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1130,11 +1130,17 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
</p>

<div className="stream-template-editor">
<label
htmlFor="template-name-input"
className="visually-hidden"
>
Template name
</label>
<input
id="template-name-input"
value={templateNameInput}
onChange={(e) => setTemplateNameInput(e.target.value)}
placeholder="e.g. Monthly Contributor Payroll"
aria-label="Template name"
/>
<div className="stream-template-editor__actions">
<button
Expand Down Expand Up @@ -1214,9 +1220,13 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
{requiredFieldsCompleted} / 5 required fields completed
</p>
</div>
<label className="stream-form__template-select">
<label
htmlFor="template-select"
className="stream-form__template-select"
>
Load template
<select
id="template-select"
value={selectedTemplateId ?? ""}
onChange={(e) => {
const id = e.target.value;
Expand All @@ -1237,9 +1247,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
</label>
</div>

<label>
<label htmlFor="stream-recipient">
Recipient Address
<input
id="stream-recipient"
required
type="text"
value={streamForm.recipient}
Expand All @@ -1250,9 +1261,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
/>
</label>
<div className="stream-form__row">
<label>
<label htmlFor="stream-token">
Token
<input
id="stream-token"
required
type="text"
value={streamForm.token}
Expand All @@ -1262,9 +1274,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
placeholder="USDC"
/>
</label>
<label>
<label htmlFor="stream-total-amount">
Total Amount
<input
id="stream-total-amount"
required
type="number"
min="0"
Expand All @@ -1278,9 +1291,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
</label>
</div>
<div className="stream-form__row">
<label>
<label htmlFor="stream-starts-at">
Starts At
<input
id="stream-starts-at"
required
type="datetime-local"
value={streamForm.startsAt}
Expand All @@ -1289,9 +1303,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
}
/>
</label>
<label>
<label htmlFor="stream-ends-at">
Ends At
<input
id="stream-ends-at"
required
type="datetime-local"
value={streamForm.endsAt}
Expand All @@ -1302,9 +1317,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
</label>
</div>
<div className="stream-form__row">
<label>
<label htmlFor="stream-cadence">
Cadence (seconds)
<input
id="stream-cadence"
type="number"
min="1"
step="1"
Expand All @@ -1315,9 +1331,10 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
/>
</label>
</div>
<label>
<label htmlFor="stream-note">
Note
<textarea
id="stream-note"
value={streamForm.note}
onChange={(e) => updateStreamForm("note", e.target.value)}
placeholder="Optional internal note for this stream configuration."
Expand Down Expand Up @@ -1464,4 +1481,4 @@ export function DashboardView({ session, onDisconnect }: DashboardViewProps) {
)}
</main>
);
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"devDependencies": {
"husky": "^9.1.7",
"lint-staged": "^17.0.7",
"vitest": "^2.1.8"
"vitest": "^3.2.7"
},
"lint-staged": {
"frontend/**/*.{ts,tsx,js,jsx}": [
Expand Down
Loading