-
-
Notifications
You must be signed in to change notification settings - Fork 166
feat: Move generated app state to XDG state/cache dirs #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e0ca6d1
cb8adba
6260779
f8843ec
1085069
46e98b0
dcd2113
3f4aa8a
04b9460
9de4fc7
7b8140d
bf31e42
a3d4444
f454876
09a82c7
81168de
0d403d9
26a0d5f
a102b38
bee9afd
863be30
b20d9c4
c0b8cbe
cccc3d0
d3bc833
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,18 +21,28 @@ privileges, so read anything you install from elsewhere (see | |
| Single-file plugins go straight into `plugins/`: | ||
|
|
||
| ```bash | ||
| cp track-notifier.lua ~/.config/spotatui/plugins/ | ||
| case "${XDG_CONFIG_HOME:-}" in | ||
| /*) config_home="$XDG_CONFIG_HOME" ;; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: this is more shell than the thing it installs. The five-line |
||
| *) config_home="$HOME/.config" ;; | ||
| esac | ||
| mkdir -p "$config_home/spotatui/plugins" | ||
| cp track-notifier.lua "$config_home/spotatui/plugins/" | ||
| ``` | ||
|
|
||
| Directory plugins (a folder with a `main.lua` entry point) are copied as a whole: | ||
|
|
||
| ```bash | ||
| cp -r session-stats ~/.config/spotatui/plugins/ | ||
| case "${XDG_CONFIG_HOME:-}" in | ||
| /*) config_home="$XDG_CONFIG_HOME" ;; | ||
| *) config_home="$HOME/.config" ;; | ||
| esac | ||
| mkdir -p "$config_home/spotatui/plugins" | ||
| cp -r session-stats "$config_home/spotatui/plugins/" | ||
| ``` | ||
|
|
||
| Restart spotatui after installing. Plugins that register commands need a key binding; add one to | ||
| `~/.config/spotatui/config.yml` under `plugin_commands` (each plugin documents a suggested key in | ||
| its header comment). | ||
| `config.yml` in the spotatui app config directory under `plugin_commands` (each | ||
| plugin documents a suggested key in its header comment). | ||
|
|
||
| To install a plugin published as a git repository, use the built-in installer instead: | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: LargeModGames/spotatui
Length of output: 2197
🏁 Script executed:
Repository: LargeModGames/spotatui
Length of output: 397
🏁 Script executed:
Repository: LargeModGames/spotatui
Length of output: 37142
🏁 Script executed:
Repository: LargeModGames/spotatui
Length of output: 3151
Correct the native streaming cache migration claim.
This entry says native streaming caches are not migrated automatically, but
legacy_path_migration_moves_directory_when_target_is_emptymigratesconfig/streaming_cacheto<cache>/streaming_cachewhen the cache target is empty. Tell users that legacy native streaming credentials and audio cache can migrate; otherwise they may expect a re-login that does not happen.🤖 Prompt for AI Agents