feat(ltk_overlay): route non-audio overrides out of localized champio… - #177
Open
moonshadow565 wants to merge 1 commit into
Open
feat(ltk_overlay): route non-audio overrides out of localized champio…#177moonshadow565 wants to merge 1 commit into
moonshadow565 wants to merge 1 commit into
Conversation
…n WADs Original localized champion WADs (X.<locale>.wad.client) only ever hold locale-tagged VO audio, yet mods routinely pack their entire content into one (46 of 2309 mods in the reference corpus). New chunks declared there previously stayed in the localized WAD: invisible to players on any other locale, and unresolvable for the closed-world base-skin verification, which fails the whole overlay at injection. Pass 1 now re-homes the fallback target per chunk: an override declared under a localized champion WAD whose bytes are not a Wwise audio container (same LeagueFileKind detection the WAD writer uses for compression) falls back to the champion's real WAD instead. Audio keeps the declared target — genuine localized content is exactly VO — and non-champion localized WADs (Localized/ string tables) are untouched. Known chunks also stop being cross-copied into the localized WAD, since the delocalized fallback is already among their index matches. Cache invalidation: routing decisions from earlier builds must not survive this change. - meta_cache CACHE_VERSION 5 -> 6: the per-mod metadata cache persists each override's fallback_wad, so cached entries carry pre-delocalization targets; the bump discards them and forces pass-1 re-collection on the next build. - OverlayState CURRENT_VERSION 5 -> 6: overlay WADs on disk were built under the old routing and no longer match what a fresh build would produce; the version mismatch forces one full rebuild and disables the exact-match skip and incremental reuse for pre-upgrade state. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
moonshadow565
force-pushed
the
localized_routing
branch
from
July 15, 2026 21:33
faeebd0 to
0cb7726
Compare
Member
|
This needs to get rebased. Also feel free to take a look at the LTK Manager overlay builder wrapper routine which handles this downstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clanker-writen, will go thru it eventually.