feat(workflows): add ephemeral environment prune and update ephemeral workflow - #406
Open
onouguier-ledger wants to merge 3 commits into
Open
feat(workflows): add ephemeral environment prune and update ephemeral workflow#406onouguier-ledger wants to merge 3 commits into
onouguier-ledger wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+8
to
+15
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checking out | ||
| uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6 | ||
| - name: Remove argocd preview tags | ||
| run: gh pr list --label argocd/preview --json number --jq '.[].number' | xargs -I {} gh pr edit {} --remove-label argocd/preview | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
fsamier
reviewed
Dec 2, 2025
| remove-ephemeral-tags: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checking out |
Contributor
There was a problem hiding this comment.
Do we need checkout for a only changing PR labels?
Contributor
Author
There was a problem hiding this comment.
gh cli needs a git repo AFAIK.
Contributor
There was a problem hiding this comment.
I'm using it repo-less with full URL in input, for instance gh pr merge https://github.com/LedgerHQ/crypto-assets/pull/2260. However I don't know if it's easily applicable here
Contributor
There was a problem hiding this comment.
This works in any directory (if you have the appropriate rights ofc) for instance:
$ gh pr list --repo LedgerHQ/crypto-assets(docs)
So I think you can manage to skip the checkout part with the correct context variables
onouguier-ledger
marked this pull request as ready for review
April 27, 2026 09:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.