Skip to content

Add Dalamud API13 compatibility#85

Closed
kirin-xiv wants to merge 2 commits into
LeonBlade:mainfrom
kirin-xiv:api13-compatibility-clean
Closed

Add Dalamud API13 compatibility#85
kirin-xiv wants to merge 2 commits into
LeonBlade:mainfrom
kirin-xiv:api13-compatibility-clean

Conversation

@kirin-xiv

Copy link
Copy Markdown

Summary

This PR adds API13 compatibility to BDTH. I had originally updated my fork for personal use when the API transition happened, and am now contributing the changes back upstream for the community.

Changes Made

  • Project file: Added <DalamudApiLevel>13</DalamudApiLevel> property
  • SDK: Already using Dalamud.NET.Sdk/13.0.0

Testing

  • Builds successfully with 2 existing warnings (unrelated to API13)
  • Plugin loads and functions correctly in-game
  • Note: Plugin validation shows "no config UI callback" warning, but functionality is intact

Context

I needed BDTH working with API13 for my own setup, so I made these minimal changes in my fork. Since the plugin works well with these updates, I thought it would be helpful to contribute them back so other users can benefit from continued API13 compatibility.

This is a minimal change that brings BDTH up to date with the latest Dalamud API requirements without disrupting existing functionality.

@jackandcarter

jackandcarter commented Aug 9, 2025

Copy link
Copy Markdown

I'm also working on finishing the work on the other branch to help out, its done just have to test, and your contribution will also help make that happen, so thanks :P

Comment thread BDTHPlugin/BDTHPlugin.csproj Outdated
<PropertyGroup>
<Version>1.6.9</Version>
<TargetFramework>net9.0-windows</TargetFramework>
<DalamudApiLevel>13</DalamudApiLevel>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is necessary?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not necessary. Tested after removing it and its fine.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL I don't have to explicitly define the API level in my plugins lol

@LeonBlade LeonBlade closed this Aug 10, 2025
@kirin-xiv kirin-xiv deleted the api13-compatibility-clean branch August 10, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants