Add Dalamud API13 compatibility#85
Closed
kirin-xiv wants to merge 2 commits into
Closed
Conversation
|
I'm also working on finishing the work on the other branch to help out, its done just have to test, and your contribution will also help make that happen, so thanks :P |
LeonBlade
reviewed
Aug 9, 2025
| <PropertyGroup> | ||
| <Version>1.6.9</Version> | ||
| <TargetFramework>net9.0-windows</TargetFramework> | ||
| <DalamudApiLevel>13</DalamudApiLevel> |
Author
There was a problem hiding this comment.
It's not necessary. Tested after removing it and its fine.
Author
There was a problem hiding this comment.
TIL I don't have to explicitly define the API level in my plugins lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds API13 compatibility to BDTH. I had originally updated my fork for personal use when the API transition happened, and am now contributing the changes back upstream for the community.
Changes Made
<DalamudApiLevel>13</DalamudApiLevel>propertyTesting
Context
I needed BDTH working with API13 for my own setup, so I made these minimal changes in my fork. Since the plugin works well with these updates, I thought it would be helpful to contribute them back so other users can benefit from continued API13 compatibility.
This is a minimal change that brings BDTH up to date with the latest Dalamud API requirements without disrupting existing functionality.