Bags: Bag and Bank Columns sliders, and fix Window Scale not rescaling an open bank - #1
Draft
LiQiuDGG wants to merge 1 commit into
Draft
Bags: Bag and Bank Columns sliders, and fix Window Scale not rescaling an open bank#1LiQiuDGG wants to merge 1 commit into
LiQiuDGG wants to merge 1 commit into
Conversation
…en bank Bag Columns exposes the existing bagColumns setting; Bank Columns adds bankColumns, defaulting to 14 to match the previous hardcoded value so nothing changes without opting in. Window Scale guarded on _G.EUI_Bank, which is a local and therefore always nil, so an open bank never rescaled. The frame's real global is EUI_BankFrame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Two changes in the Bags module.
Bag Columns / Bank Columns sliders. Adds one options row exposing the grid width of the bag and bank windows.
bagColumnsalready existed in the profile at12but was not reachable from the options page.bankColumnsis new and defaults to14, the valueCOLUMNShas always been hardcoded to inEllesmereUIBags/EllesmereUIBags_Bank.lua. Both windows therefore look exactly as they did until a slider is moved. The warband bank follows Bank Columns.bankColumnsis added to the migration profile key list inEllesmereUI_Migration.luaso it carries across profiles and presets.Window Scale on an open bank. The Window Scale setter guarded on
_G.EUI_Bank, which is alwaysnil:EUI_Bankis a file local, and the frame's global name isEUI_BankFrame(EllesmereUIBags/EllesmereUIBags_Bank.lua:209). The guard never passed, so dragging Window Scale while the bank was open did nothing. The bank already applies the samebagScalevalue on open (EllesmereUIBags/EllesmereUIBags_Bank.lua:2374), so only the live update was affected; closing and reopening the bank picked the new scale up. The fix uses the real global.How was it tested?
Live on
12.1.0(client120100), running a package of this branch built fromv9.0.0./console scriptErrors 1for the whole session, no errors/reloadbankColumnscarries across a profile switchScreenshots
Before, on stock
v9.0.0:1. Bank open, Window Scale
100.2. Window Scale
130. The inventory rescales; the bank, already open, does not.After, on this branch. Each step changes one thing:
3. Defaults, Bag Columns
12and Bank Columns14.4. Bag Columns
16and Bank Columns18, Window Scale unchanged.5. Window Scale
125, columns unchanged. The bank now rescales.6. The new options row at its defaults.
Checklist
12for bags and14for the bank, so nothing changes for anyone who does not move them.bankColumnsinside its existing refresh path.HookScript/hooksecurefunconly, neverSetScripton Blizzard frames — not applicable, only EllesmereUI's own frames are touched.