Faster exercise entry with inline fuzzy suggestions - #752
Closed
MohamedKiouaz wants to merge 3 commits into
Closed
Conversation
Owner
|
I think I like this approach in terms of searching. What I'd say is there is probably a case for only searching the saved exercises, and as a separate piece of work make it so that exercises within workouts are persisted into the exercise list |
Owner
|
There's definitely something to this work. I'll pull it down and play with it. I think it's time that we force all exercises to be selected from that list. To do this we would want to make adding exercises to that list seamless and easy |
Owner
|
I've integrated the fuzzy matching here I've still kept the bottom sheet for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most important workflow improvement for me. To work around the current input flow, I keep a long Freeform Workout as a fallback list of 20+ exercises I might use, just so I can get through a session without getting stuck.
I track very strictly, and the current flow is a bad look when training with friends: I end up on my phone for too long, have to make sure the exercise name matches previous sessions exactly, and often have to translate names from French to English before saving.
Implementation:
Extracted from the main dev branch in #724