Skip to content

remove use_persis_return_sim plus mypy fixes#1715

Open
jlnav wants to merge 2 commits intodevelopfrom
refactor/rm_use_persis_return_sim
Open

remove use_persis_return_sim plus mypy fixes#1715
jlnav wants to merge 2 commits intodevelopfrom
refactor/rm_use_persis_return_sim

Conversation

@jlnav
Copy link
Copy Markdown
Member

@jlnav jlnav commented Apr 14, 2026

No description provided.

@jlnav jlnav marked this pull request as ready for review April 14, 2026 20:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.39%. Comparing base (089ea5e) to head (e1dff97).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1715      +/-   ##
===========================================
+ Coverage    91.83%   92.39%   +0.56%     
===========================================
  Files           81       81              
  Lines         8251     8247       -4     
  Branches      1268     1267       -1     
===========================================
+ Hits          7577     7620      +43     
+ Misses         472      420      -52     
- Partials       202      207       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlnav jlnav requested a review from shuds13 April 17, 2026 17:38
@shuds13
Copy link
Copy Markdown
Member

shuds13 commented Apr 28, 2026

Is the persistent sim example still getting tested.

Remove the sim and gen versions of this variable - check no persistent sim or gen is returning data that is not needed (ie. dupcliate of whatever was returned in loop). When they should return, you can see something with update H after loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants