Skip to content

[CCUBE-2090][XY] Add WISE product themes - #1443

Open
ninjasheeps wants to merge 7 commits into
masterfrom
wise-themes
Open

[CCUBE-2090][XY] Add WISE product themes#1443
ninjasheeps wants to merge 7 commits into
masterfrom
wise-themes

Conversation

@ninjasheeps

@ninjasheeps ninjasheeps commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

  • Links to Figma:

Colours

  1. WISE
  2. VICA
  3. WebSG
  4. WOGAA

Typography

  1. WISE - Public
  2. WISE - Admin
  • Added 4 WISE product themes: WISE, VICA, WebSG, WOGAA
  • Add fontVariant prop in ThemeProvider to set data-fds-font

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests

@ninjasheeps
ninjasheeps requested a review from qroll August 28, 2026 05:38
@qroll
qroll requested a review from ziggyzet August 28, 2026 06:07
@qroll qroll added the type: enhancement New feature or request label Aug 28, 2026

@ziggyzet ziggyzet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the screenshots for the E2E

Comment thread src/theme/styles/websg.css Outdated
Comment thread .storybook/preview.css Outdated
Comment thread src/theme/theme-provider/index.tsx Outdated
Comment thread src/theme/theme-provider/index.tsx Outdated
Comment thread stories/theme/font/p-font-wise.mdx Outdated
Comment thread stories/theme/font/p-font-wise.mdx Outdated
Comment thread src/theme/styles/spf.css
Comment thread src/theme/theme-provider/types.ts Outdated
@qroll

This comment was marked as resolved.

Comment thread src/theme/styles/vica.css Outdated
Comment thread src/theme/styles/vica.css Outdated
ghazwan-gt
ghazwan-gt previously approved these changes Sep 1, 2026
ziggyzet
ziggyzet previously approved these changes Sep 1, 2026
Comment thread src/theme/theme-provider/hooks.tsx Outdated
Comment thread src/theme/theme-provider/index.tsx
Comment thread src/theme/types.ts Outdated
Comment thread src/theme/types.ts Outdated
Comment thread e2e/nextjs-app/src/app/components/[component]/[story]/layout.tsx Outdated
Comment thread src/theme/styles/wise.css Outdated
@ninjasheeps
ninjasheeps dismissed stale reviews from ziggyzet and ghazwan-gt via 9675921 September 2, 2026 07:14
@ninjasheeps
ninjasheeps requested a review from qroll September 2, 2026 07:14
Comment thread src/theme/styles/vica.css Outdated
Comment thread src/theme/theme-provider/types.ts Outdated
@ninjasheeps
ninjasheeps requested a review from qroll September 3, 2026 02:34
@qroll

qroll commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

we just merged in some masthead changes which will affect the navbar as well. as such, the new navbar screenshots need to be updated

need to rebase the branch, npm ci, and regenerate the screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants