Skip to content

[CCUBE-2273][ZZ] feat: update Navbar drawer item styling - #1446

Open
ziggyzet wants to merge 6 commits into
masterfrom
ZZ/CCUBE-2273
Open

[CCUBE-2273][ZZ] feat: update Navbar drawer item styling#1446
ziggyzet wants to merge 6 commits into
masterfrom
ZZ/CCUBE-2273

Conversation

@ziggyzet

Copy link
Copy Markdown
Contributor

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing apis or functionality to change)
  • Documentation (change to documentation, comments or API descriptions)
  • Tests (improvements to unit tests or E2E tests)
  • Other (technical improvements, refactoring, or changes that don't fall into the above categories)

Description of changes

Checklist

  • Changes follow the project guidelines in CONTRIBUTING.md and CONVENTIONS.md
  • Looks good on mobile and tablet
  • Updated documentation
  • Added/updated unit tests
  • Added/updated E2E tests

Screenshots

@ziggyzet
ziggyzet requested review from ghazwan-gt and qroll August 28, 2026 08:07
@ziggyzet ziggyzet self-assigned this Aug 28, 2026
Comment thread src/navbar/navbar-items.styles.ts Outdated
Comment thread src/navbar/navbar-items.tsx
Comment thread src/navbar/navbar-items.tsx Outdated
Comment thread src/navbar/navbar-items.tsx
@qroll qroll added the type: enhancement New feature or request label Aug 30, 2026
Comment thread src/navbar/navbar-items.tsx Outdated
@ziggyzet
ziggyzet requested a review from qroll September 2, 2026 03:55

@qroll qroll left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

desktops looks correct, but checking on mobile behaviour

in the SubMenu story, if I set initial selected id as guides-item-2, but click on home, the mobile submenu for Guides remains expanded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants