fix(cli): merge partial scenario updates - #7
Open
92Infinitus92 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PATCH /v1/scenarios/{id}.This backend change should be merged before
LimeChain/surfpool-web-ui#8, because the Studio PR sends partial PATCH bodies.Greptile Summary
The PR updates scenario PATCH handling to merge partial updates while preserving omitted fields and retaining full-document upsert compatibility.
Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[PATCH /v1/scenarios/id] --> B{Scenario exists?} B -->|Yes| C[Merge supplied fields into stored scenario] B -->|No| D[Parse full document for upsert] C --> E[Force ID from request path] D --> E E --> F{Valid Scenario with known fields?} F -->|Yes| G[Replace or insert scenario] F -->|No| H[Return 400 without mutation]Reviews (2): Last reviewed commit: "fix(cli): reject unknown scenario upsert..." | Re-trigger Greptile