elbepack: finetuning: fix losetup usage for command in losetup element - #472
Open
koalo wants to merge 2 commits into
Open
elbepack: finetuning: fix losetup usage for command in losetup element#472koalo wants to merge 2 commits into
koalo wants to merge 2 commits into
Conversation
needs_loop_device listed partition-command (which is actually the type of the element) instead of command. This leads to commands in losetup no longer having access to a mounted image and thus fail. Fixes: d2d5925 ("elbepack: finetuning: avoid losetup where possible") Signed-off-by: Florian Kauer <florian.kauer@linutronix.de>
Add a unit test to verify that elements that really need losetup get proper losetup and vice versa. Signed-off-by: Florian Kauer <florian.kauer@linutronix.de>
Contributor
|
Thanks! I picked up the bugfix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs_loop_device listed partition-command (which is actually the type of the
element) instead of command. This leads to commands in losetup no longer
having access to a mounted image and thus fail.
Fixes: d2d5925 ("elbepack: finetuning: avoid losetup where possible")
Also add unit test that fails without the bug fix.