pytest: general image validation fixes - #473
Closed
kanavin wants to merge 2 commits into
Closed
Conversation
t-8ch
reviewed
Jul 29, 2026
t-8ch
reviewed
Jul 29, 2026
…ons with the original archive file This works if the script is run directly, but fails when it is embedded into build_dir/source.xml, and then written out from there into a temp dir and executed by 'elbe check-build'. At that point the link to the original directory with the xml and archive is long-lost. We cannot hardcode the permissions to the file either, as they vary between build hosts (see 79cd5df) so let's simply drop the permissions check and only check that file exists and is a regular file. Signed-off-by: Alexander Kanavin <alex@linutronix.de>
…can be logged into The login check, in turn, requires setting a root password on the image, and adjusting the script to check for its presence. With this commit, running 'elbe check-build img' on pre-built simple-validation-image is finally passing both qemu login test and offline validation script: $ ./elbe check-build img ./elbe-build-20260727-155040/ ... [INFO]Succesfully validate 2 images out of 2 [INFO]Passed 1 tests ouf of 1 It's also possible to execute an integrated pytest that builds the image and doesn't require a manual pre-build, but it is much slower due to also building the sdk and cdrom: $ pytest -s -k "simple-validation-image.xml-img" --runslow --elbe-use-initvm=existing Signed-off-by: Alexander Kanavin <alex@linutronix.de>
kanavin
force-pushed
the
fix-slow-pytests
branch
from
July 29, 2026 15:42
2a4a6f7 to
e19728b
Compare
Contributor
|
Applied, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see specific commits in this PR. They enable adding particular base-extended tests, and commits for those will follow in a separate PR.
With this PR, running 'elbe check-build img' on pre-built simple-validation-image
is executing and passing both qemu login test and offline validation script:
It's also possible to execute an integrated pytest that builds the image
and doesn't require a manual pre-build, but it is much slower due to
also building the sdk and cdrom: