Skip to content

Prepare the testing infrastructure for testing base image tarballs - #474

Closed
kanavin wants to merge 0 commit into
Linutronix:masterfrom
kanavin:add-base-extended-validation
Closed

Prepare the testing infrastructure for testing base image tarballs#474
kanavin wants to merge 0 commit into
Linutronix:masterfrom
kanavin:add-base-extended-validation

Conversation

@kanavin

@kanavin kanavin commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

The actual tarballs tests are still being worked on, but in the process I've had to modify and refactor a few existing pieces. To make reviews more manageable, the changes are being offered in a pull request ahead of the actual tarball implementation.

@kanavin
kanavin force-pushed the add-base-extended-validation branch from d21edd9 to f288359 Compare August 5, 2026 11:22
@kanavin

kanavin commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

pytest is failing due to broken ubuntu mirror :-/

@t-8ch t-8ch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied the last three patches.

Comment thread elbevalidate/imagetests.py Outdated
@@ -0,0 +1,356 @@
# ELBE - Debian Based Embedded Rootfilesystem Builder
# SPDX-License-Identifier: GPL-3.0-or-later
# SPDX-FileCopyrightText: 2026 Linutronix GmbH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elbevalidate package is meant for generic testing utilities, usable by everyone.
It is meant to be distributed as part of the Debian packages.

The functions here now don't fit this criteria. They are very much specific to the ELBE testing itself.

Also the testscript is inlined into the ELBE XML, for better traceability.
Moving the policy into the ELBE installation, is counter to this.

I am all for reusing the testing code. Maybe we can just use the same script for both tests and distinguish at runtime which image is being tested.
Or extend the XML to pass parameters to the script. (More effort)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the image name can be obtained from build_dir/source.xml with a pytest fixture, e.g. simple-validation-image has:

<project>
                <name>simple-validation-image</name>

Then the tests can parametrize themselves based on that value, or fail to run if the name isn't something they know. You ok with that?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good.

Comment thread elbevalidate/imagetests.py Outdated
@kanavin
kanavin force-pushed the add-base-extended-validation branch from f288359 to d063217 Compare August 5, 2026 16:13
@kanavin kanavin closed this Aug 6, 2026
@kanavin
kanavin force-pushed the add-base-extended-validation branch from d063217 to 3e0c977 Compare August 6, 2026 10:21
@kanavin
kanavin deleted the add-base-extended-validation branch August 6, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants