Skip to content

fix(virtual-hid): remove license expiration - #5517

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/virtual-hid-license
Aug 17, 2026
Merged

fix(virtual-hid): remove license expiration#5517
ReenigneArcher merged 1 commit into
masterfrom
fix/virtual-hid-license

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Aug 17, 2026

Copy link
Copy Markdown
Member

Description

Fix annual licensing issue with Virtual HID Driver.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bundle Report

Changes will decrease total bundle size by 51 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sunshine-esm 877.81kB -51 bytes (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sunshine-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/logo-*.js -37 bytes 384.37kB -0.01%
assets/troubleshooting-*.js -14 bytes 14.75kB -0.09%

Files in assets/logo-*.js:

  • ./src_assets/common/assets/web/public/assets/locale/en.json → Total Size: 46.17kB

Files in assets/troubleshooting-*.js:

  • ./src_assets/common/assets/web/troubleshooting.html → Total Size: 0 bytes

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review August 17, 2026 17:54
@codecov

codecov Bot commented Aug 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.08%. Comparing base (687e12d) to head (0a9e743).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

❗ There is a different number of reports uploaded between BASE (687e12d) and HEAD (0a9e743). Click for more details.

HEAD has 28 uploads less than BASE
Flag BASE (687e12d) HEAD (0a9e743)
macOS-x86_64 3 1
Homebrew-ubuntu-24.04 3 1
Windows-AMD64 3 1
Windows-ARM64 3 1
macOS-arm64 3 1
FreeBSD-amd64 3 1
Homebrew-macos-14 3 0
Homebrew-macos-26 3 0
FreeBSD-aarch64 3 0
Linux-AppImage 3 1
Archlinux 3 1
Homebrew-macos-15 3 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5517      +/-   ##
==========================================
- Coverage   32.40%   23.08%   -9.33%     
==========================================
  Files         104      103       -1     
  Lines       24931    24019     -912     
  Branches    11077    10771     -306     
==========================================
- Hits         8079     5544    -2535     
+ Misses      14728    14220     -508     
- Partials     2124     4255    +2131     
Flag Coverage Δ
Archlinux 0.00% <ø> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 18.16% <ø> (+<0.01%) ⬆️
Homebrew-macos-14 ?
Homebrew-macos-15 ?
Homebrew-macos-26 ?
Homebrew-ubuntu-24.04 18.83% <ø> (-0.01%) ⬇️
Linux-AppImage 18.25% <ø> (-0.01%) ⬇️
Windows-AMD64 23.62% <100.00%> (ø)
Windows-ARM64 20.35% <55.55%> (+0.02%) ⬆️
macOS-arm64 25.22% <ø> (+<0.01%) ⬆️
macOS-x86_64 25.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/confighttp.cpp 40.30% <ø> (-14.14%) ⬇️
src/system_tray.cpp 72.81% <100.00%> (-7.66%) ⬇️

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687e12d...0a9e743. Read the comment docs.

@ReenigneArcher
ReenigneArcher merged commit 6aece1b into master Aug 17, 2026
63 of 70 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/virtual-hid-license branch August 17, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant