build(homebrew): normalize remapped LCOV source paths - #5518
Conversation
|
Bundle ReportBundle size has no change ✅ |
Updates `lcov_for_source_file_record` to normalize `SF:` paths with `Pathname.cleanpath` and correctly handle Homebrew/LLVM remapped relative paths (including `build/tests/src/...` and already-relative `src/...` entries). It now rewrites valid source paths to `src/...` and skips non-source records. Adds coverage assertions in the formula test to verify remapped, compile-dir-relative, relative, absolute, and excluded test paths are handled correctly.
3a8a570 to
617f40c
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5518 +/- ##
==========================================
+ Coverage 23.08% 31.72% +8.64%
==========================================
Files 103 104 +1
Lines 24019 24912 +893
Branches 10774 11062 +288
==========================================
+ Hits 5544 7904 +2360
+ Misses 16061 14716 -1345
+ Partials 2414 2292 -122
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
|



Description
Updates
lcov_for_source_filesinpackaging/sunshine.rbto handle Homebrew shim-rewritten paths (./src/...) and already-relativesrc/...entries, while still supporting absolute paths via known source prefixes. Adds a test case to verify all three path forms are normalized tosrc/...and that non-source entries (like./tests/...) are excluded.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.