fix(input): add missing default value for key_rightalt_to_key_win - #5519
fix(input): add missing default value for key_rightalt_to_key_win#5519AliceJump wants to merge 2 commits into
Conversation
The input_t aggregate initializer in config.cpp omits the key_rightalt_to_key_win member, so every subsequent field is shifted and native_pen_touch (the final member) is value-initialized to false instead of its intended default of true. As a result, when native_pen_touch is absent from the config file, pen/touch input is disabled even though the surrounding comment suggests it defaults to enabled. Add the missing initializer and add a unit test asserting the default.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 129bb05d96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Correct the initializer added in the previous commit to use false, matching the documented and configured default (apply_config resets it to false before reading the option). Using true would make aggregate-default consumers (tests, helpers) treat Right Alt as the Windows-key mapping before config parsing. Extend the default test to cover the inserted member.
ReenigneArcher
added
the
ai
|
Thank you for the PR submission, but it looks like you used AI to create this PR. Please read and follow our Contributing guidelines and specifically our AI Usage policy. Additionally, please update the PR to use the correct template. You can find it at https://github.com/LizardByte/.github/blob/master/.github/pull_request_template.md?plain=1 |
|
|
Thank you for the correction. I have updated the PR description to use the correct template and declared the AI usage. |
2 participants
Description
Fixes a regression where touch/pen input is disabled when
native_pen_touchisomitted from the config file.
Root cause: the
input_taggregate initializer insrc/config.cppis missingan entry for
key_rightalt_to_key_win. This shifts every subsequent field byone, so
native_pen_touch(the final member) is value-initialized tofalseinstead of its intended default of
true. The surrounding commenttrue, // native pen/touch supportis misleading because that value actuallyinitializes
high_resolution_scrolling.This change adds the missing initializer (
key_rightalt_to_key_windefaults tofalse, matching its configured default) and adds unit tests covering bothdefaults.
Verified locally: with
native_pen_touchabsent fromsunshine.conf, I ran thereleased build (
2026.808.164219) and confirmed touch/pen input was broken,then rebuilt from this branch and confirmed touch/pen input works. The
ConfigInputTestcases pass.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.