Support jellyfin PUBLIC_PLAYLIST visibility#126
Open
paubineau wants to merge 1 commit intoLumePart:devfrom
Open
Support jellyfin PUBLIC_PLAYLIST visibility#126paubineau wants to merge 1 commit intoLumePart:devfrom
paubineau wants to merge 1 commit intoLumePart:devfrom
Conversation
paubineau
force-pushed
the
jellyfin-public_playlist-support
branch
from
d27f435 to
e0fe8d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Edit: I recreated this PR after reorganizing the branches in my fork. It is identical to the previous one, which was closed unintentionally.)
Without diving into multi-user playlist support, i wanted to be able to choose the explo playlist visibility within a jellyfin setup.
The PR fixes Jellyfin playlist creation to use the actual Jellyfin user ID (resolved from SYSTEM_USERNAME) instead of incorrectly using the API key as UserId. Playlist ownership is hence correctly set to the defined user, allowing to choose playlist visibility.
It reuses existing PUBLIC_PLAYLIST env var to control the explo playlist visibility within jellyfin, keeping config changes minimal.
Note that since it reuses the PUBLIC_PLAYLIST default value, explo playlist in jellyfin would be private by default with this changes (same as the subsonic behaviour). It was public by default without this pr changes.