build: node 24 image, handover plugin, current CI action tags - #1
Merged
Conversation
- Base image on node:24-alpine; install handover plugin from HNSDNS/handover at /opt/hsd/handover with a node_modules symlink (Node 24 refuses TS type stripping under node_modules; hsd loads plugins via loader: require(name)). - Publish hsd:latest on master pushes (latest tag was gated on non-master). - Bump workflow actions: checkout v7, setup-node v7, metadata-action v6, setup-qemu v4, setup-buildx v4, login-action v4, build-push-action v7, coveralls v2, actions-gh-pages v4; docs workflow to node 24.
Coverage Report for CI Build 33832360064Warning No base build found for commit Coverage: 71.653%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bases the image on node:24-alpine and installs the handover plugin (HNSDNS/handover) at /opt/hsd/handover, symlinked into node_modules so
loader: requireresolves it — Node 24 won't type-strip .ts under a node_modules tree, so the real install must live outside it.Flips the
latesttag gate in docker.yml so master pushes publishhsd:latest(it was gated on non-master refs, so master only ever producededge).Bumps all workflow actions to current tags: checkout v7, setup-node v7, metadata-action v6, setup-qemu v4, setup-buildx v4, login-action v4, build-push-action v7, coveralls v2, actions-gh-pages v4. docs.yml moves from node 16 to 24 (verified
jsdoc -c jsdoc.jsonruns clean on v24.20).