fix(spec): constrain namespace, website, and SSL status enums - #119
Merged
Conversation
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
pcfreak30
marked this pull request as ready for review
September 4, 2026 13:11
Code Coverage ReportTotal Coverage: 13.5% Generated from commit: 384a7d4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
swagger.yamlto the live service spec and regenerates the client.Adds enum constraints for domain/gateway/DANE
namespace(icann, hns),domain status (draft through onchain_managed), and SSL status (pending,
issuing, ready, failed). Codegen now prefixes the upload status enum
constants, so
internalclient.Completedbecomesinternalclient.UploadResultResponseStatusCompleted, and the SSL statusfield is a named type; wrapper updates and test adjustments follow.
This PR syncs the SDK with the API specification by constraining several string fields to enums in the generated client code. Specifically:
DomainDANERepublishResponseandDomainResponseare now typed enums with allowed values (icann/hnsfor namespace, anddraft,records_generated,waiting_delegation,active,self_hosted,error,onchain_managedfor status).SSLStatusInfois now an enum with valuespending,issuing,ready,failed.swagger.yaml) was updated to include these enum constraints, keeping the spec and generated client in sync.websites.gonow explicitly casts the enum to a string when returning.This change strengthens type safety, prevents invalid values from being sent or received, and ensures the SDK adheres to the official API contract.