fix(websites): alias DomainNamespace to generated enum - #121
Merged
Conversation
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
pcfreak30
force-pushed
the
feat/export-domain-response-namespace
branch
from
September 4, 2026 13:28
4540eb8 to
2ce71f4
Compare
pcfreak30
marked this pull request as ready for review
September 4, 2026 13:28
Code Coverage ReportTotal Coverage: 13.5% Generated from commit: f934b77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aliases
DomainNamespaceto the generatedDomainResponseNamespaceinstead of duplicating it as a standalone string type, and points its
constants at the generated enum values.
DomainNamespaceOfnow returnsthe response field directly.
The
DomainNamespacetype has been updated to alias the generatedinternalclient.DomainResponseNamespaceenum instead of being a standalone string type. This change ensures that domain namespaces always match the client’s API values and reduces the risk of drift or invalid values.Key modifications:
DomainNamespaceis now a type alias tointernalclient.DomainResponseNamespace.DomainNamespaceICANNandDomainNamespaceHNSnow reference the corresponding generated enum values (DomainResponseNamespaceIcannandDomainResponseNamespaceHns).DomainNamespaceOfnow returns the namespace directly from the response without an explicit cast, since it is already the correct type.This makes the SDK more consistent with the underlying API and removes the need for manual conversion.