Skip to content

fix(websites): alias DomainNamespace to generated enum - #121

Merged
pcfreak30 merged 1 commit into
developfrom
feat/export-domain-response-namespace
Sep 4, 2026
Merged

fix(websites): alias DomainNamespace to generated enum#121
pcfreak30 merged 1 commit into
developfrom
feat/export-domain-response-namespace

Conversation

@pcfreak30

@pcfreak30 pcfreak30 commented Sep 4, 2026

Copy link
Copy Markdown
Member

Aliases DomainNamespace to the generated DomainResponseNamespace
instead of duplicating it as a standalone string type, and points its
constants at the generated enum values. DomainNamespaceOf now returns
the response field directly.


The DomainNamespace type has been updated to alias the generated internalclient.DomainResponseNamespace enum instead of being a standalone string type. This change ensures that domain namespaces always match the client’s API values and reduces the risk of drift or invalid values.

Key modifications:

  • DomainNamespace is now a type alias to internalclient.DomainResponseNamespace.
  • The constants DomainNamespaceICANN and DomainNamespaceHNS now reference the corresponding generated enum values (DomainResponseNamespaceIcann and DomainResponseNamespaceHns).
  • DomainNamespaceOf now returns the namespace directly from the response without an explicit cast, since it is already the correct type.

This makes the SDK more consistent with the underlying API and removes the need for manual conversion.

@kody-ai

kody-ai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@pcfreak30
pcfreak30 force-pushed the feat/export-domain-response-namespace branch from 4540eb8 to 2ce71f4 Compare September 4, 2026 13:28
@pcfreak30
pcfreak30 marked this pull request as ready for review September 4, 2026 13:28
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

Code Coverage Report

Total Coverage: 13.5%

Generated from commit: f934b77
Repository: LumeWeb/ipfs-sdk

@pcfreak30
pcfreak30 merged commit 80cb955 into develop Sep 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant