feat(portal-plugin-dashboard): use SafeAuthenticated guard in routes - #1154
Merged
Conversation
- replace legacy @refinedev/core Authenticated on account/dashboard/ operations layouts with the auth package's SafeAuthenticated, which reads the to param once and sanitizes the redirect target
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the dashboard plugin's account, dashboard, and operations
routes from the legacy
@refinedev/coreAuthenticatedguard toSafeAuthenticatedfrom portal-framework-auth, which reads thetoquery param once and sanitizes the redirect target before navigating.
Summary
This pull request updates the authentication guard used in the dashboard plugin's routing to use the
SafeAuthenticatedcomponent from@lumeweb/portal-framework-authinstead of the genericAuthenticatedcomponent from@refinedev/core.Changes
account.layout.tsxdashboard.tsxoperations.tsxv3LegacyAuthProviderCompatibleprop from all usages.SafeAuthenticatedfrom@lumeweb/portal-framework-authin favor of the previous Refine import.Impact