screenshot: Call vkInvalidateMappedMemoryRanges, request host cached memory#2686
Open
th3or14 wants to merge 2 commits into
Open
screenshot: Call vkInvalidateMappedMemoryRanges, request host cached memory#2686th3or14 wants to merge 2 commits into
th3or14 wants to merge 2 commits into
Conversation
Call vkInvalidateMappedMemoryRanges before reading the mapped memory on the host because the mapped memory is created without VK_MEMORY_PROPERTY_HOST_COHERENT_BIT.
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
th3or14
changed the title
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
Attempt to create the mapped memory with VK_MEMORY_PROPERTY_HOST_CACHED_BIT for performance boost. Fallback on a memory type without this property if it's not supported.
|
Author th3or14 not on autobuild list. Waiting for curator authorization before starting CI build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #2685. @charles-lunarg Please review.