Testing phase of Ledi Firmware#176
Open
Gobind-Kailey wants to merge 4 commits into
Open
Conversation
Member
|
Can you restore all the other files you deleted? Was that intentional or by accident |
chosterto
reviewed
Jun 22, 2026
Comment on lines
+13
to
+15
| pinMode(PIN_LED_RED, OUTPUT); | ||
| pinMode(PIN_LED_GREEN, OUTPUT); | ||
| pinMode(PIN_LED_BLUE, OUTPUT); |
Member
There was a problem hiding this comment.
I know this is just for testing, but eventually we will need to change how we control the LEDs (may require a more precise method for controlling PWM, like DMA?)
Author
There was a problem hiding this comment.
Yeah the basic pin setup is just to verify the micro-Ros state machine is working. I agree, we are going to require a DMA driver for the LEDs. I think I should finish testing this state machine first and then move on to creating that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated code from "teensy.ino" to implement the changes required by LEDI at URC,