Introduction of massive RAMBO in standalone_mg7.#5
Merged
Conversation
Additional key, error and case to obtain masses in get_meta()
Same as in standalone_cpp, will need vectorization in future. Copy of it to dir.
Same as the massless RAMBO, for now internal RNG and not splitted into the inital and final state particles sampling
New flag -r [c|ml] (classic, massless) Flag only for perf - matrix always massive Massive host only so for now copy to device self RNG inside Massless kept for back compability for now RNG outside (we pass buffer with rnd numbers)
Qubitol
reviewed
Jun 15, 2026
| << "Usage:\n" | ||
| << " " << argv0 << " [matrix] [-v|--verbose]\n" | ||
| << " " << argv0 << " perf [-v|--verbose] [-f|--flavor <int>]" | ||
| << " " << argv0 << " perf [-v|--verbose] [-f|--flavor <int>] [-r|--rambo [c]|ml]" |
Member
There was a problem hiding this comment.
Given the default is classic and it makes total sense, I would just add a flag --rambo-massless which works as a switch.
Qubitol
reviewed
Jun 15, 2026
| #include "MemoryAccessRandomNumbers.h" | ||
| #include "MemoryAccessWeights.h" | ||
| #include "MemoryBuffers.h" | ||
| #include "classic_rambo.h" // inline classic (massive) RAMBO, ported from standalone_cpp |
Member
There was a problem hiding this comment.
Maybe we can call it just rambo.h given it is the sane default, while the other becomes massless_rambo.h?
Qubitol
requested changes
Jun 15, 2026
Qubitol
left a comment
Qubitol
left a comment
Member
There was a problem hiding this comment.
Just some general comments on namings. It looks good for the rest. Given now we have a proper rambo implementation, I would make it default all the way through (including the name) and treat the massless rambo as a special case.
naming changed to rambo.h and massless_rambo.h flag instead of switch (--rambo-massless)
stloufra
force-pushed
the
feat-madmatrix-rambo
branch
from
e24b940 to
6f599e8
Compare
Qubitol
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now Host only, if MGONGPUCPP_GPUIMPL momenta buffer copy from host to device
Uses its own internal RNG - to be decided if to be kept
New flag in check_sa perf -r [c|ml] (classic or massless)
Default for both modes is massive (classic)
New get_meta option in umami to retrieve masses from CPPProcess