modernize CMake target setup for clean embedding - #11
Merged
Conversation
MangelSpec
commented
Jun 13, 2026
MangelSpec
commented
Owner
- Scope build flags (RTTI, warnings, /EHsc) PRIVATE so v8pp's build choices no longer propagate to consumers; keep only the V8 ABI defines and the C++20 requirement public
- Build RTTI-free (-fno-rtti / /GR-): v8pp uses no typeid/dynamic_cast, so this matches V8's -fno-rtti ABI and removes the consumer/V8 typeinfo conflict that broke -fno-rtti subclasses of V8 base types
- Express the standard via target_compile_features(cxx_std_20) and pin v8pp's own sources to C++20, replacing global CMAKE_CXX_* state; move /Zc:__cplusplus to the target's private MSVC options
- Accept absolute custom-V8 paths (CUSTOM_V8_*_ABS) and skip the standalone install when embedded (V8PP_SKIP_INSTALL)
- Document the build-system behavior in README
- Scope build flags (RTTI, warnings, /EHsc) PRIVATE so v8pp's build choices no longer propagate to consumers; keep only the V8 ABI defines and the C++20 requirement public - Build RTTI-free (-fno-rtti / /GR-): v8pp uses no typeid/dynamic_cast, so this matches V8's -fno-rtti ABI and removes the consumer/V8 typeinfo conflict that broke -fno-rtti subclasses of V8 base types - Express the standard via target_compile_features(cxx_std_20) and pin v8pp's own sources to C++20, replacing global CMAKE_CXX_* state; move /Zc:__cplusplus to the target's private MSVC options - Accept absolute custom-V8 paths (CUSTOM_V8_*_ABS) and skip the standalone install when embedded (V8PP_SKIP_INSTALL) - Document the build-system behavior in README
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.