fix(#48): _simulate_values now uses cost model fidelity and warns users - #100
Merged
Merged
Conversation
_simulate_values used a hardcoded base_fidelity=0.85 instead of the cost model's fidelity estimate, producing arbitrary results without any warning to users. Fix: Store the circuit in execute() and use cost_model.estimate_fidelity to get actual circuit fidelity. Fall back to 0.85 only if no circuit is available. Emit UserWarning when simulated values are used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes _simulate_values which used hardcoded fidelity=0.85. Now uses cost_model.estimate_fidelity for actual circuit fidelity, falling back to 0.85 only when no circuit is available. Emits UserWarning when simulated values are used. 3 new regression tests. All 347 tests pass.