fix(#50): centralize duplicated default constants in utils.py - #102
Merged
Conversation
Default error rates (0.0005, 0.01, 0.015), T2 time (150e-6), and gate durations (50e-9, 300e-9) were hardcoded in cost_model.py, cutting.py, scheduling.py, and utils.py. Updating one would miss the others. Fix: Define DEFAULT_SINGLE_QUBIT_ERROR, DEFAULT_TWO_QUBIT_ERROR, DEFAULT_READOUT_ERROR, DEFAULT_T2_TIME, DEFAULT_SINGLE_QUBIT_GATE_TIME, DEFAULT_TWO_QUBIT_GATE_TIME as module-level constants in utils.py. Import and use them in cost_model.py, cutting.py, and scheduling.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defines DEFAULT_SINGLE_QUBIT_ERROR, DEFAULT_TWO_QUBIT_ERROR, DEFAULT_READOUT_ERROR, DEFAULT_T2_TIME, DEFAULT_SINGLE_QUBIT_GATE_TIME, DEFAULT_TWO_QUBIT_GATE_TIME as module-level constants in utils.py. Replaces 6 hardcoded values across cost_model.py, cutting.py, scheduling.py, and utils.py. All 349 tests pass.