fix(#51): use deterministic hashlib.sha256 instead of Python hash() - #103
Merged
Conversation
_compute_core_hash used Python's hash() which is salted with a random seed in Python 3.3+, producing different hashes across interpreter sessions and breaking persistent caching reproducibility. Fix: Replace hash(tuple) with hashlib.sha256(str(tuple).encode()) converted to int. Same circuit always produces the same hash. Add 2 regression tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces non-deterministic Python hash() in _compute_core_hash with hashlib.sha256. Same circuit now produces the same hash across interpreter sessions, fixing persistent caching. 2 regression tests. All 351 tests pass.