Skip to content

RB fix detecting invalid requirements - #226

Open
nicopop wants to merge 4 commits into
mainfrom
RB-fix-catching-invalid-requirements
Open

RB fix detecting invalid requirements#226
nicopop wants to merge 4 commits into
mainfrom
RB-fix-catching-invalid-requirements

Conversation

@nicopop

@nicopop nicopop commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

as stated in #201 here's a pr to fix some of the RB issues I found while testing

  1. Having unbalanced parentheses sometime crashes recursively_tokenize_manual_rule
  2. Having any invalid function that ends with a 1 or 0 ends up not triggering any protection since infix_to_postfix skip any char it doesn't like instead of raising an error.
    a. Since the fix adds calls to construct_logic_error in infix_to_postfix I feel we could rename the LogicErrorSource enum values to better fit what they are now for.
  3. RB warnings only uses print so they do not leave traces in the logs

@nicopop nicopop self-assigned this Aug 14, 2026
@nicopop nicopop changed the title RB fix catching invalid requirements RB fix detecting invalid requirements Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants