Minor Client tweaks - #228
Open
silasary wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing an audit of Best Practices across a bunch of my worlds, and I noticed that Manual is doing a couple things that are very much "This was written in 2023 and never looked at since"
This PR does a couple very small things:
CommonContext.check_locationsinstead of building the LocationChecks packet directly.Syncpackets. Sync asks for a full recap of every item from Index 0. Generally it's only needed if the client detects a desync and needs to reset the whole inventory. I'm not sure why we're doing this, but we don't need to, and it wastes a decent amount of bandwidth.