Fix build on macOS arm64 - #65
Open
rnkn wants to merge 11 commits into
Open
Conversation
Author
|
I figured out how to build entirely with the system |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. There are a few things in this PR. The main changes are discussed in #64
The Makefile was overriding
CFLAGSandLDFLAGSso I've changed those.I've also changed the build process to not use
OBJDIR. I found this a bit clunky:and I think this is neater and permits resuming an interrupted build without running
make cleanand starting from scratch.I've also required a system
fmtlibinstead of building in repo.I have not, however, removed theformat.ccobject required for building. (I don't really understand this tbh.)I understand if you don't want to merge this. It's mainly for my own interest.