tests: Add Iceberg sink scenarios in limits, platform-checks, improve parallel-workload#34913
Merged
Merged
Conversation
def-
force-pushed
the
pr-iceberg-sink-testing
branch
14 times, most recently
from
4281285 to
a9b6c61
Compare
Contributor
Author
|
Status: Blocked by opened issues: https://github.com/MaterializeInc/database-issues/issues/10079 & https://github.com/MaterializeInc/database-issues/issues/10080 |
def-
force-pushed
the
pr-iceberg-sink-testing
branch
4 times, most recently
from
0f020f8 to
790431b
Compare
def-
force-pushed
the
pr-iceberg-sink-testing
branch
5 times, most recently
from
98246bd to
0d0487c
Compare
def-
force-pushed
the
pr-iceberg-sink-testing
branch
2 times, most recently
from
3fb8e16 to
155fc35
Compare
Contributor
Author
|
Ready for review |
def-
force-pushed
the
pr-iceberg-sink-testing
branch
from
155fc35 to
1fee4ba
Compare
def-
force-pushed
the
pr-iceberg-sink-testing
branch
from
1fee4ba to
246e208
Compare
Contributor
Author
|
New test run: https://buildkite.com/materialize/nightly/builds/16745 |
bosconi
approved these changes
Jun 11, 2026
bosconi
left a comment
bosconi
left a comment
Member
There was a problem hiding this comment.
Looks good. A couple of things I was unsure about.
| CREATE SECRET s3_secret (TYPE S3, KEY_ID '${iceberg_user}', SECRET '${iceberg_key}', ENDPOINT 'minio:9000', URL_STYLE 'path', USE_SSL false, REGION 'minio'); | ||
| SET unsafe_enable_version_guessing = true; | ||
|
|
||
| # TODO: How to verify the data? |
Member
There was a problem hiding this comment.
Would it work to assert the sink is still running and that messages_committed advances, like kafka-sink-statistics.td does?
Contributor
Author
There was a problem hiding this comment.
Would be better to check in iceberg or have an iceberg source and reingest into Materialize.
… parallel-workload
def-
force-pushed
the
pr-iceberg-sink-testing
branch
from
246e208 to
3314d42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run: https://buildkite.com/materialize/nightly/builds/16745
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.