fix: correct web_search_tool spec injection and warn on raw_ddl conflict - #15
Merged
Conversation
…ct (closes #14) The DDL-level TOOLS = ({TYPE = WEB_SEARCH_TOOL}) clause emitted by the previous implementation fails Snowflake's parser. Replace it with a spec-level tool_spec entry appended to the specification YAML, which is the syntax Snowflake actually accepts. Also emit a compile-time warning when web_search_tool, comment, or profile configs are set alongside raw_ddl=true, since those configs were previously silently dropped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOOLS = ({ TYPE = WEB_SEARCH_TOOL })clause (which fails Snowflake's parser) with a spec-leveltool_specentry appended to theFROM SPECIFICATIONYAML body — the syntax Snowflake actually accepts.exceptions.warn(...)whenweb_search_tool,comment, orprofileconfigs are set alongsideraw_ddl=true, since those configs were previously silently dropped.Closes #14.
Test plan
dbt compileon a spec-mode model withweb_search_tool=true— confirmtools: - tool_spec:appears inside$$...$$, no DDL-levelTOOLS = (...)clausedbt compilewithraw_ddl=true+web_search_tool=true— confirm warning is printed and DDL is unchangeddbt compilewith noweb_search_tool— confirm notools:injectiondbt runagainst Snowflake withweb_search_tool=true— confirm agent deploys without parse errors🤖 Generated with Claude Code