fix(memos-local-plugin): harden hermes bridge lifecycle#1667
Open
liuhaibin0528 wants to merge 1 commit intoMemTensor:mainfrom
Open
fix(memos-local-plugin): harden hermes bridge lifecycle#1667liuhaibin0528 wants to merge 1 commit intoMemTensor:mainfrom
liuhaibin0528 wants to merge 1 commit intoMemTensor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This hardens the Hermes stdio bridge lifecycle for
apps/memos-local-plugin.bridge.cts --agent=hermesprocesses on client closefeedback.submitfailures so they do not abortsync_turnturn.endand a shorter timeout forfeedback.submitWhy
In long-running Hermes sessions I hit two stability problems repeatedly:
feedback.submitcould make the whole turn sync look failed even thoughturn.endhad already completedThis patch keeps the viewer daemon behavior intact while making the short-lived stdio bridge process lifecycle explicit.
Testing
python3 -m unittest apps.memos-local-plugin.tests.python.test_bridge_clientpython3 -m unittest apps.memos-local-plugin.tests.python.test_hermes_provider_pipeline