Abort analyse step when parse errors occur#578
Open
jordansilly77-stack wants to merge 1 commit into
Open
Conversation
Matthew Hambley (MatthewHambley)
requested changes
Jul 21, 2026
Matthew Hambley (MatthewHambley)
left a comment
Collaborator
There was a problem hiding this comment.
This looks like a useful change but your raising it pointed out that we didn't have a contributors agreement in place. We now do so you'll need to deal with that before this change can progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_for_errorshelper for consistent step behaviourCloses #577.
Tests
.venv/bin/python -m pytest tests/unit_tests/steps/test_analyse.py tests/unit_tests/steps/test_steps.py.venv/bin/python -m flake8 source/fab/steps/analyse.py tests/unit_tests/steps/test_analyse.pyI also ran
.venv/bin/python -m pytest tests/unit_tests/steps; unrelatedtest_find_source_filescases fail locally because no Fortran compiler is available.