Skip to content

Fail analyse step when parser errors occur#580

Open
jordansilly77-stack wants to merge 1 commit into
MetOffice:mainfrom
jordansilly77-stack:fix/analyse-errors-abort
Open

Fail analyse step when parser errors occur#580
jordansilly77-stack wants to merge 1 commit into
MetOffice:mainfrom
jordansilly77-stack:fix/analyse-errors-abort

Conversation

@jordansilly77-stack

Copy link
Copy Markdown

Closes #577

Summary

  • fail the analyse step when parser/analyser results contain exceptions
  • reuse the existing error-reporting helper for consistent behaviour
  • update unit coverage for the new failure path

Tests

  • git diff --check
  • uv run --with '.[dev]' python -m flake8 source/fab/steps/analyse.py tests/unit_tests/steps/test_analyse.py\n- uv run --with '.[dev]' python -m pytest tests/unit_tests/steps/test_analyse.py tests/unit_tests/steps/test_steps.py -q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Fab does not abort in case of analyse errors

1 participant