Convert jules_pftparm to a duplicate namelist; one namelist per PFT#132
Draft
Maggie (maggiehendry) wants to merge 17 commits into
Draft
Conversation
…mented * Only 5 PFTs like LFRic apps currently
…ion written as a function.
… However, the code won't run as I haven't updated it to recognise the added PFTs.
…art from `usr_types`.
…ed changes to upgrade macro.
…licate namelists.
* Macro split into two initially to investigate the um script hang, but is useful to see what corrections have had to be implemented before splitting into indiviual namelists. - How rivers dealt with changed as it didn't validate against the metadata. - UM metadata amendments removed for pftparm. - c_z0h_z0m now broadcast to fix UM bug.
github-actions
Bot
added
the
cla-required
Maggie (maggiehendry)
changed the title
jules_pftparm to a duplicate namelist; one namelist per PFT
…melist items. * New irrigation scheme tiles added to mapping and upgrade bugs fixed.
|
Hello Maggie (@maggiehendry)! 👋 Thank you for your contribution. Since this is your first time contributing to this repository, we ask that you sign our Contributor Licence Agreement (CLA). To agree to the CLA, please add your details (GitHub username, Real Name, Affiliation, and Date) to the CONTRIBUTORS.md file (create one, if required) in the development branch for this PR. After signing the CLA, you won't need to do this again for future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
readability of the code
rose-meta/jules-sharedthen have you supplied a linked UM and LFRic Apps PR?Testing
stem suites
acceptable (eg. kgo changes)
tests, unit tests, etc.)
trac.log
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
Approvals
Please request all relevant approvals. See the CodeOwners.txt file for section
owners.
Technical
Scientific
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review